User "NeilK" posted a comment on MediaWiki.r99941.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99941#c24902
Commit summary:
Applied modified patch by Ben Hartshorne <bhartshorne at wikimedia dot org>:
Leverage MW 1.18's improved image metadata extraction to automatically
extract GPS coordinates, add them to the review workflow, and add a
{{Location dec}} template to the file description page if they have been
provided. This also adds a latitude/longitude fields that the user can
manually fill in, which ultimately should be replacd with a location
picker widget.
Tested in IE7, IE8, Chrome 13, Opera 10, FF7, with single and multiple
files, with and without coordinates.
Comment:
to clarify, the validation library I want is jquery.validate.js -- you can see
examples of how it's used throughout UploadWizard, whenever ".rules" and
".messages" are invoked.
basically we need to:
- have a hidden <label> in the form, with a for= attribute for these fields,
with the mwe-validator-error class, so it can be called in case of an error.
Look at the other examples.
- add .rules to these elements with min(value) and max(value) for lat and long,
and possibly add a 'required' which checks: if one is nonblank, then the other
is required.
- add .messages for each rule (the error if the value isn't correct)
- obviously, add the entries in UploadWizard.i18n.php and UploadWizardHooks.php
for the new messages
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
