User "Johnduhart" posted a comment on MediaWiki.r100605.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100605#c24836
Commit summary:

makes HTML5 five only attributes a global property

This patch move an array hidden in Html::expandAttributes() to the top of
the class definition as self::$HTMLFiveOnlyAttribs.
That also make the Html::expandAttributes() method a bit more concise.

Comment:

<pre>+                  if ( !$wgHtml5 && in_array( $key, 
self::$HTMLFiveOnlyAttribs )
+                        ) {
</pre>

Should be on one line but that's a nitpick.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to