User "Catrope" posted a comment on MediaWiki.r101488.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101488#c25276
Commit summary:
Cache the result of User::getDefaultOptions(), so the UserGetDefaultOptions
hook (introduced in r97365) is run only once rather than on every call.
Discovered this issue after seeing an insane number of memcached fetches in my
RL2 code, caused by a UserGetDefaultOptions hook accessing the Gadgets storage
backend (which has a memc layer) and being called a zillion times due to this
bug.
Comment:
For future reference, the parser test failures were these:
<pre>
Internal link with ca linktrail with apostrophes (bug 27473)
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-<p><a href="/index.php?title=Something&action=edit&redlink=1"
class="new" title="Something (encara no existeix)">Something'nice</a>
+<p><a href="/index.php?title=Something&action=edit&redlink=1"
class="new" title="Something (page does not exist)">Something'nice</a>
</p>
Internal link with kaa linktrail with apostrophes (bug 27473)
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-<p><a href="/index.php?title=Something&action=edit&redlink=1"
class="new" title="Something (bet ele jaratılmag'an)">Something'nice</a>
+<p><a href="/index.php?title=Something&action=edit&redlink=1"
class="new" title="Something (page does not exist)">Something'nice</a>
</p>
-{}- tags within headlines (within html for parserConvert())
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-<h2><span class="editsection">[<a
href="/index.php?title=Parser_test&action=edit&section=1"
title="Уредите одељак „Naslov“">уреди</a>]</span> <span class="mw-headline"
id="-.7BNaslov.7D-"> Naslov </span></h2>
+<h2><span class="editsection">[<a
href="/index.php?title=Parser_test&action=edit&section=1" title="Edit
section: Naslov">edit</a>]</span> <span class="mw-headline"
id="-.7BNaslov.7D-"> Naslov </span></h2>
Bug31490 Turkish: ucfırst (with a dotless i)
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-<p><a
href="/index.php?title=%C5%9Eablon:Ucf%C4%B1rst:blah&action=edit&redlink=1"
class="new" title="Şablon:Ucfırst:blah (sayfa mevcut
değil)">Şablon:Ucfırst:blah</a>
+<p><a
href="/index.php?title=%C5%9Eablon:Ucf%C4%B1rst:blah&action=edit&redlink=1"
class="new" title="Şablon:Ucfırst:blah (page does not
exist)">Şablon:Ucfırst:blah</a>
</p>
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
