User "Catrope" posted a comment on MediaWiki.r101492.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101492#c25277
Commit summary:
Apply Vitaliy Filippov's patch from Bug #29283 with some small style mods
Comment:
<pre>
+ public function get( $code, $key ) {
+ $k = wfMemcKey( 'l10n', $code, 'k', $key );
+ return $this->cache->get( $k );
+ }
+
</pre>
Doesn't the LCStore_Accel class just duplicate the one for memcached but with a
different value for $this->cache? If so, it would be nice to use inheritance to
remove the code duplication.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
