User "F.trott" changed the status of MediaWiki.r102049. Old Status: fixme New Status: new
User "F.trott" also posted a comment on MediaWiki.r102049. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102049#c25538 Commit summary: followup 102038: finer-grained escaping Comment: I changed Xml::tags to manually opening and closing the tag because HTML tag attribute values need to be escaped, while the elements content does not need to be escaped as it is already valid HTML. Neither Xml::tag nor Xml::element provide that functionality. For whether <button> may contain content or not I suggest looking it up in a reference, e.g. https://developer.mozilla.org/en/HTML/Element/button. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
