User "Jpostlethwaite" posted a comment on MediaWiki.r102084. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102084#c25573 Commit summary:
Changed getText() to getVal() where a null value was specified. Several of these just had the null second parameter removed because it was not necessary to be null. Comment: It was suggested we change them to reflect the proper usage of the function. I added all of the direct debit with the null. I saw no reason to keep them as null, since they were using getText(). Is there a problem with them being an empty string? An empty string is what will be put in the form element, so it seems logical to deliver an empty string, instead of null. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
