User "Khorn (WMF)" posted a comment on MediaWiki.r102084. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102084#c25574 Commit summary:
Changed getText() to getVal() where a null value was specified. Several of these just had the null second parameter removed because it was not necessary to be null. Comment: Well, for one instance, see getTransactionSpecificValue in the gateway.adapter (search the function for 'is_null'). This builds all our communication with the remote gateways, and the communication could vary drastically if it sees what it will identify as an explicitly sent blank string, and a piece of data that was missing or not sent at all. True, all blank fields in a form will be an empty string. However, we do not know at the time of raw data population that this was even a form post from DonationInterface. There is a lot of processing to be done before we get to the point where we are populating form fields, and we need to be able to easily tell if any given value was explicitly passed in as an empty string, or if it was not passed in at all. Setting absent values to an empty string by default removes that ability. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
