User "Catrope" posted a comment on MediaWiki.r102607. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102607#c25818 Commit summary:
Updated tests and test data to support listItem nodes being branches instead of leafs Comment: <pre> - deepEqual( - selectNodesTests[i].node.selectNodes( selectNodesTests[i].input, selectNodesTests[i].shallow ), - selectNodesTests[i].output, - selectNodesTests[i].desc + var result = selectNodesTests[i].node.selectNodes( + selectNodesTests[i].input, selectNodesTests[i].shallow + ); + ok( + compare( result, selectNodesTests[i].output ), </pre> WHYYYYYYY? deepEqual() gives very useful diff output when the comparison fails. Your ok()+compare() combo just gives a red box and no other information whatsoever. (But it is hella faster.) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
