User "Trevor Parscal" posted a comment on MediaWiki.r102607. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102607#c25841 Commit summary:
Updated tests and test data to support listItem nodes being branches instead of leafs Comment: Deep equal pisses me off because it goes bonkers on our nodes, and make the output as useless as the red box. This way, we can know if a test is failing quickly doing a "what matters" comparison, and if something is broken, we can just add a debugger or console.dir statement to the code to fix it. Unit testing and debug output don't need to always be united - as long as the results are correct we are in good shape. I say use deep equal unless it's ridiculous to do so, and in this case I think it is. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
