User "Petrb" posted a comment on MediaWiki.r103146. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103146#c26036 Commit summary:
New performance fix, now it checks if there is a need to do delete before performing it, it needs extra select but that is less expensive than delete (croned it's still faster) this needs to be reviewed by someone who knows sql, it's possible that executing empty delete (0 rows are matched by condition) doesn't take more time than than executing empty select + it's even possible that it doesn't replicate db in that case if that is true, fix me + some fixes :) Comment: it doesn't matter, the delete is not important, it only clean up the table, so if there is insert between select and delete it wouldn't change much, the function which checks if user is online has the timestamp check too, so if there would be some old records it wouldn't matter anyway, best would be if this delete was performed like every 30 minutes or so. but I don't think php can do cron-like stuff _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
