User "Petrb" posted a comment on MediaWiki.r103146. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103146#c26037 Commit summary:
New performance fix, now it checks if there is a need to do delete before performing it, it needs extra select but that is less expensive than delete (croned it's still faster) this needs to be reviewed by someone who knows sql, it's possible that executing empty delete (0 rows are matched by condition) doesn't take more time than than executing empty select + it's even possible that it doesn't replicate db in that case if that is true, fix me + some fixes :) Comment: as Ian suggested to me, it's better not to call too many "changing" sql's, because cluster which consist from master and slaves, needs to replicate data when something get updated, so I just inserted that select there to prevent needless delete, it is there just to reduce table size. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
