User "Kaldari" changed the status of MediaWiki.r103246. Old Status: new New Status: ok
User "Kaldari" also posted a comment on MediaWiki.r103246. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103246#c26157 Commit summary: Lots more work on the GlobalCollect command-line orphan rectifier. Modified a couple things in the main GC adapter class where appropriate, and added a subclass (will have to be added to autoload in LocalSettings by itself: Didn't want this loading anywhere by default) just for dealing with orphans. Added an empty directory where a master list of orphaned order ids, and a bunch of logfiles should be stashed before the script is run. Comment: <pre> + $pos1 = strpos($line_data, '<ORDERID>') + 9; + $pos2 = strpos($line_data, '</ORDERID>'); + if ($pos2 > $pos1){ ... </pre> Might be good to explain what you're doing here. Also, using continues makes code harder to read IMO, might want to just stick the statements below it within the if statement and reverse the operator:<br/> if (count($orders) < $this->max_per_execute){ _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
