User "Dantman" posted a comment on MediaWiki.r103893. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103893#c26337 Commit summary:
Implement a number of namespace related equals functions: * MWNamespace::equals to test equivalence of two namespaces (forward compatible with any changes we may make like introducing namespace keys like 'USER') * MWNamespace::subjectEquals to test equivalence of the subject of two namespaces e.g.: MWNamespace::subjectEquals( NS_USER, $ns ); instead of testing for equivalence to both NS_USER and NS_USER_TALK * Title::inNamespace to use instead of $title->getNamespace() == NS_??? * Title::inNamespaces for use like $title->inNamespaces( NS_USER, NS_PROJECT ) when you only care if it's in one of a number of namespaces (also accepts an array) * Title::hasSubjectNamespace for use instead of testing for equivalence to both the subject and talk such as NS_USER and NS_USER_TALK. Include phpunit tests for all this new code, and also add some tests for some existing code. Comment: Sure... that's a possibility. Though it'll have even more friction than this change. Every current getNamespace() == NS_USER may break and we'll have to have an entirely new class because MWNamespace has static functions and we'll need to switch to instance methods. I'll think about that. We'll probably need a new Title method though. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
