User "Dantman" posted a comment on MediaWiki.r103893. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103893#c26406 Commit summary:
Implement a number of namespace related equals functions: * MWNamespace::equals to test equivalence of two namespaces (forward compatible with any changes we may make like introducing namespace keys like 'USER') * MWNamespace::subjectEquals to test equivalence of the subject of two namespaces e.g.: MWNamespace::subjectEquals( NS_USER, $ns ); instead of testing for equivalence to both NS_USER and NS_USER_TALK * Title::inNamespace to use instead of $title->getNamespace() == NS_??? * Title::inNamespaces for use like $title->inNamespaces( NS_USER, NS_PROJECT ) when you only care if it's in one of a number of namespaces (also accepts an array) * Title::hasSubjectNamespace for use instead of testing for equivalence to both the subject and talk such as NS_USER and NS_USER_TALK. Include phpunit tests for all this new code, and also add some tests for some existing code. Comment: getNamespaceObj was the one name I could come up with too. Though, TBH that '-Obj' pattern feels like that kind that extension developers will consider a little ugly and potentially decide to just opt to keeping getNamespace() without ever bothering to even start using the new interface in their code. I almost wish we would have started with a bad naming scheme like getNS. If we were using a name like that we could make use of that as an excuse to switch to a better name like getNamespace for the new api... but we're not. I can't quite think of any name nicer than getNamespace. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
