User "Platonides" posted a comment on MediaWiki.r104563.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104563#c26711
Commit summary:

Fix fatal error when running newParserTest

The delayed parser test feature was expecting a ParserTest object which is
almost never the case when using the NewParserTest for PHPUnit. The class
name is forged after the file name! They at least all extends NewParserTest

no polymorphism? no multiple hinting. Be creative the PHP way by writing
your own code :-(

Comment:

Forging it from the name was easy and much more convenient than eg. 
md5(mt_rand()) :)

In an ideal world, ParserTest and NewParserTest wouldn't duplicate code.

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to