"Johnduhart" changed the status of MediaWiki.r104629 to "fixme" and commented
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104629#c26856
Old Status: new
> New Status: fixme
Commit summary for MediaWiki.r104629:
Rearranged the jquery plugin a bit to pull markup into its own section:
- Added $.articleFeedbackv5.templates with the help tooltip and the
generic
clear block
- Added $.articleFeedbackv5.enableSubmission() with the shared
functionality and a call to a bucket-specific version, if one exists
- For each bucket:
- Created a templates object with the block markup, as well as
tag
markup for bucket 2 and rating markup for bucket 5
- Updated buildForm() to get the template from templates.block
- Updated buildForm() to pull in the template for the tooltip
where
appropriate
- Removed enableSubmission(), except for bucket 5 where it does
something special
First pass with bucket 3:
- ArticleFeedbackv5.i18n.php:
- Added bucket3 messages
- ArticleFeedbackv5.hooks.php:
- Updated message tags passed to modules
- modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js:
- $.articleFeedbackv5.buckets[3]:
- Cleaned up markup to add templates where needed
- Updated buildForm() to set the ratings labels
- Updated bindEvents() to add the mouseover/out/down
for ratings,
the clear button, and switching out the default text
Added bucket 4 messages to ArticleFeedbackv5.i18n.php
Set a default tag on bucket 2
Johnduhart's comment:
{{Messagedocumentation}}
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
