"Johnduhart" changed the status of MediaWiki.r104715 to "fixme" and commented
it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104715#c26857
Old Status: new
> New Status: fixme
Commit summary for MediaWiki.r104715:
Added section links, and feedback links now tracked internally:
- sql/ArticleFeedbackv5.sql and alter.sql:
- Added aft_article_feedback.af_link_id
- ArticleFeedbackv5.i18n.php:
- Added messages for the link text
- modules/jquery.articleFeedbackv5/jquery.articleFeedbackv5.js:
- New property $.articleFeedbackv5.linkId
- New method $.articleFeedbackv5.setLinkId()
- Updated $.articleFeedbackv5.submitForm to send the link id in
the
ajax call
- Plugin can now take an options object, nothing, or a string
for a
public method (right now, just "setLinkId")
- modules/ext.articleFeedbackv5/ext.articleFeedbackv5.js:
- Renamed some variables for clarity
- Created a generic function for any feedback link from the
existing
one used on the toolbox link
- Clicking a feedback link calls $.articleFeedbackv5.setLinkId()
- Added feedback links after the edit section links
- ApiArticleFeedbackv5:
- Updated getFeedbackId() to save the link id
- Updated getAllowedParams() and getParamDescription() to add
"link"
- ArticleFeedbackv5.hooks.php:
- Updated the messages for module ext.articleFeedbackv5.js to
remove
the old pitch messages and add the feedback link messages
Bug fix: Removed "ext.articleFeedbackv5.js" as a dependency from
"ext.articleFeedbackv5.startup.js"; it was mistakenly added because
$wgArticleFeedbackv5LotteryOdds was set to zero and hadn't been updated
in
my local settings -- this was causing the widget to appear in the wrong
places, like the edit page.
Johnduhart's comment:
{{Messagedocumentation}}
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
