"Brion VIBBER" posted a comment on MediaWiki.r105154. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105154#c27065
Commit summary for MediaWiki.r105154: * Made resetDB() actually clear out the tables rather than leave the contents * Removed destroyDB(); unused and broken (does not use prefix) Brion VIBBER's comment: that line appears to be in new code, not old code. Was this the foreach($tables as $table) in destroyDB()? It kinda looks like that's only needed on certain database types, and normally we'd use temporary tables which drop themselves... was that code even being reached on MySQL / SQLite? Or did we stop using temporary tables? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
