"Platonides" posted a comment on MediaWiki.r105154. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105154#c27249
Commit summary for MediaWiki.r105154: * Made resetDB() actually clear out the tables rather than leave the contents * Removed destroyDB(); unused and broken (does not use prefix) Platonides's comment: This produces an important slowdown in my main checkout: <table> <tr><th></th><th>r105153</th><th>r105154</th></tr> <tr><td><u>make databaseless</u></td><td>0m10.755s / 0m9.516s / 0m0.750s</td><td>0m10.938s / 0m9.733s / 0m0.740s</td></tr> <tr><td><u>make database</u></td><td>9m12.853s / 7m37.064s / 0m36.374s</td><td>51m7.904s / 19m54.749s / 1m55.319s</td></tr> <tr><td><u>make destructive</u></td><td>8m59.431s / 7m40.353s / 0m12.339s</td><td>52m38.923s / 19m48.659s / 0m40.247s<ref>I also had slower results, such as 71m40.636s / 22m0.081s / 0m49.227s in r105292, but there could be other factors there, such as a cold cache</ref></td></tr> </table> <references /> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
