"Aaron Schulz" posted a comment on MediaWiki.r104688. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104688#c27157
Commit summary for MediaWiki.r104688: Followup r104274, r104676. Fix the bug that broke fr. Forgot to rawurldecode path contents. Also add /u just for sanity sake. Add new tests for url encoding, unicode, and length edge cases. Aaron Schulz's comment: <pre> $1 will match 0 or more while the rest will match 1 or more In a pattern $1, $2, etc... will be replaced with the relevant contents'. </pre> So $1 will be replaced with a string and $2 (and beyond) with arrays? This could probably use a bit more documentation, including protected functions. The idea of this looks good. I'll need more time reviewing this and figuring it out. Are there are tests that can be added? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
