"Aaron Schulz" posted a comment on MediaWiki.r104688.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/104688#c27205
Commit summary for MediaWiki.r104688:
Followup r104274, r104676. Fix the bug that broke fr. Forgot to rawurldecode
path contents.
Also add /u just for sanity sake.
Add new tests for url encoding, unicode, and length edge cases.
Aaron Schulz's comment:
The code has:
<pre>if ( !isset( $params['title'] ) && strpos( $path, '$1' ) !== false )
{</pre>
So there has to be a $1 in there first. Though $1 will get added before that
usually, unless 'strict' is set.
I just want to make sure nothing is expecting 'title' to be set (even if just
an empty string/false) for getPathInfo(), as the comment for that function
implies that it is set.
Also, why is makeWeight() public?
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
