"Tim Starling" posted a comment on MediaWiki.r99938. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99938#c27307
Commit summary for MediaWiki.r99938: Fixup some assignments in conditionals Add/normalise some more return statements Tim Starling's comment: I don't think it's a problem to use assignment in a while() to do iteration, if the interface is designed to be used like that. It can be replaced by foreach() where there's a proper iterator available or if one can be written, that's a better alternative, but I don't think what you've done here is better. Is there some reason for doing it that I don't know about? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
