"Reedy" posted a comment on MediaWiki.r99938.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99938#c27348
Commit summary for MediaWiki.r99938:
Fixup some assignments in conditionals
Add/normalise some more return statements
Reedy's comment:
Somewhat personal preference... Assigning variables in conditional statements
has always seemed strange to me. And then somewhat due to me seeing enough
people doing if ( $foo = 'bar' ) {} unknowingly and tgetting their fingers
bitten (though, that is their fault)
I'm happy to revert the loops that don't have while -> foreach replacements if
you want
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
