"MaxSem" changed the status of MediaWiki.r107054 to "new" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107054#c28300
Old Status: ok > New Status: new Commit summary for MediaWiki.r107054: do not evaluate '<?php' line This happen when you are sending to eval.php a php file. The first line is the string '<?php' which is passed to eval(). Boom! This patch skip that string. Example usage: $ cat somefile.php <?php echo "Working!\n"; $ $ cat somefile.php | php maintenance/eval.php Working! $ MaxSem's comment: What if the file is badly written and starts with something like <tt><?php echo 'foo';</tt> ? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
