"Brion VIBBER" changed the status of MediaWiki.r107054 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107054#c28877
Old Status: new > New Status: fixme Commit summary for MediaWiki.r107054: do not evaluate '<?php' line This happen when you are sending to eval.php a php file. The first line is the string '<?php' which is passed to eval(). Boom! This patch skip that string. Example usage: $ cat somefile.php <?php echo "Working!\n"; $ $ cat somefile.php | php maintenance/eval.php Working! $ Brion VIBBER's comment: Eh, won't this also kill anything that mentions '<?php' in it? $ php maintenance/eval.php > echo '<?php'; > broken! :( _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
