"Catrope" changed the status of MediaWiki.r107093 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107093#c28353
Old Status: new
> New Status: fixme
Commit summary for MediaWiki.r107093:
added method to remove item from array by value to solve bug with reloading
item, follow up r107081
Catrope's comment:
Please don't add stuff to Array.prototype . You should be able to fix this bug
by just removing the duplication guard, it looks like it's unnecessary. Or use
an object like <code>var used = {}; used[123] = true; if ( id in used ) ....
</code>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
