"Kaldari" posted a comment on Wikimedia.r1019. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1019#c28394
Commit summary for Wikimedia.r1019: Added resetSettings(). Added $this->settings. Added ability to dequeue from pending: fetchFromPendingAndDequeue(). Fixed spelling mistakes. Kaldari's comment: <pre> + $limboId = empty( $limboId ) ? $this->getTxId() : $limboId; </pre> Why not: if ( !$limboId ) $limboId = $this->getTxId(); _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
