"Kaldari" posted a comment on Wikimedia.r1019.
URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1019#c28395
Commit summary for Wikimedia.r1019:
Added resetSettings(). Added $this->settings. Added ability to dequeue from
pending: fetchFromPendingAndDequeue(). Fixed spelling mistakes.
Kaldari's comment:
<pre>
+ $dequeue = empty( $options['dequeue'] ) ? false : (boolean)
$options['dequeue'];
...
+ if ( $dequeue ) {
</pre>
All these ternary operations make my head hurt :) Why not just:
<pre>
if ( isset( $options['dequeue'] ) && $options['dequeue'] ) {
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
