"Krinkle" posted a comment on MediaWiki.r107669.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107669#c28712

Commit summary for MediaWiki.r107669:

* more specific selectors for wikitable - don't inherit properties to nested 
tables which causes various rendering issues
** (bug 30485) Hieroglyphs look scary if embedded in tables with 
class="wikitable"
** (bug 33434) math extension: integral expressions display with 
boxes/frames/borders

Krinkle's comment:

I tested with only the <code>..table > tbody > tr ..</code> version in 
browserstack and works successfully in Chrome, Firefox 3.6+, IE7+ and Opera 
10.5+ (maybe earlier version of Opera too but don't have an older version).

This version does not work in IE6, but does the current version in SVN with 
both also does not work in IE6 (it does not support the <code>></code> child 
selector and skips this selector entirely).

According to the W3 specification user agents must and do wrap tables in tbody 
if no table containers are specified in the document (thead, tbody, tfoot). So 
we're safe there. However, as you mentioned on IRC, this is only true in HTML 
mode.

MediaWiki is in HTML5 by default, but wikis can be put it in XHTML1 mode, and 
in that mode, according to the specification, user agents must not do these 
kind of changes.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to