"Krinkle" posted a comment on MediaWiki.r107669.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107669#c28799

Commit summary for MediaWiki.r107669:

* more specific selectors for wikitable - don't inherit properties to nested 
tables which causes various rendering issues
** (bug 30485) Hieroglyphs look scary if embedded in tables with 
class="wikitable"
** (bug 33434) math extension: integral expressions display with 
boxes/frames/borders

Krinkle's comment:

I agree it is wrong to assume that kind of inheritance, I'm saying that users 
are currently seeing that and because that's what it does, it is not 
unreasonable for people to expect that after so many years.

Surely it's not a reason to not break it, simply something to keep in mind that 
users need to be told in advance so that it can be fixed where needed.

The way I usually go about these kind of changes is to put them in 
{{blue|MediaWiki:Common.css}} of commons.wikimedia and en.wikipedia and 
announce it in the Village Pump and see if there are complaints. If not, they 
can stay until after 1.19 is deployed. That ensures a smooth transition.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to