"^demon" changed the status of MediaWiki.r98422 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98422
Old status: new > New status: ok Commit summary for MediaWiki.r98422: Attempted fix for Bug #26881: noinclude tag breaks Proofread under Internet Explorer From Philippe Elie's comments explaining this patch (https://bugzilla.wikimedia.org/26881#c10) re3 = /^([\s\S]*?)<noinclude>([\s\S]*?)<\/noinclude>/; here there is two competing non-greedy group, I think FF is right by making the first one maximal, it's the same case as greedy, if there is choice for multiple ways to do a match, the match at the same level of greediness must be maximal from left to right. I guess this is why the comment talk about lookahead, because with non-greedy competition, match must be moved from right to left to implement that. The trouble is that Thomas didn't think the same things can occur with re3 if the page contains more than two <noinclude></noinclude> sequence. More boring re3 miss a final $ so only a part of the remaining part is matched and some data are lost. This works on Opera, by making both group greedy: re3 = /^([\s\S]*)<noinclude>([\s\S]*)<\/noinclude>\s*$/; I included too a \s*$ at the end to ensure if we match, we match the whole data, this way if for some reason the match fail, we will go to the if (m3) { … } else { pageBody = m2[2]; pageFooter = ''; } which ensure than no data can be lost (re2 is terminated by a $). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
