"^demon" changed the status of MediaWiki.r106021 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106021#c29036
Old Status: new
> New Status: ok
Commit summary for MediaWiki.r106021:
Fix Bug #32792 - Proofread Page extension inconsistently expects escaped spaces
in namespaces
Patch from Minh Nguyễn:
The Vietnamese localization of the Proofread Page extension uses "Mục lục"
as
the index namespace. However, the extension sometimes expects the space to
be
replaced with an underscore.
…
It's worse than that, actually: if the namespace messages use underscores,
index pages like [[s:vi:Mục lục:Viet Nam Su Luoc 1.djvu]] no longer turn
<pagelist> into a color-coded sea of Page: links, because renderPageList()'s
call to getPageAndIndexNamespace() comes back empty-handed. As a result,
prepareArticle() fails to add a "Source" tab to articles, because
prepareArticle() can't find the Index: page that links to the same Page: as
the
article.
^demon's comment:
The amount of duplication in this extension is atrocious :\
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
