"Krinkle" posted a comment on MediaWiki.r108203. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108203#c29045
Commit summary for MediaWiki.r108203: Use mw.jqueryMsg parser for message parsing to support PLURAL and GENDER Follow up r107556 and based on the discussions on wikitech-l about this. mediawiki.jqueryMsg is now loaded always. mw.msg uses the parser if required. Add qunit test cases. Krinkle's comment: I don't see how this is any different than r107556, please revert. The <code>mediawiki</code> module can't have dependencies, and adding it to another random module isn't helping the obvious race condition. And branching Message into a separate module is not a solution in the short term because of backwards compatibility. As I've asked before, what's wrong with modules needing the parser simply adding "mediawiki.jqueryMsg" as a dependency and using it ? Or if you want it to be available by default, create a "mediawiki.jqueryMsg.init" module that will extend/overwrite the message prototype and use the parser by default (so that you don;t have to do <code>mw.jqueryMsg.getMessageFunction( )</code>). Either way, this isn't working. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
