"Krinkle" posted a comment on MediaWiki.r108203.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108203#c29047

Commit summary for MediaWiki.r108203:

Use mw.jqueryMsg parser for message parsing to support PLURAL and GENDER
Follow up r107556 and based on the discussions on wikitech-l about this.
mediawiki.jqueryMsg is now loaded always. mw.msg uses the parser if required.
Add qunit test cases.

Krinkle's comment:

Also, it appears this revision is introducing a regression in the unit tests.

<pre>
6. mediawiki: mw.message & mw.messages
----
Message.escaped returns the escaped message
Expected:       
"Hello &lt;b&gt;awesome&lt;/b&gt; world"
Result: 
"Hello &lt;B&gt;awesome&lt;/B&gt; world"
Diff:   
 "Hello &lt;b&gt;awesome&lt;/b&gt; &lt;B&gt;awesome&lt;/B&gt;  world" 
</pre>

It looks like the message is parsed as HTML before it is escaped, this causes 
tagnames to become uppercase. Although this is not a big problem, there should 
be no need to parse it before escaping.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to