"Krinkle" posted a comment on MediaWiki.r108215.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108215#c29049

Commit summary for MediaWiki.r108215:

Prevent #firstHeading overriding the language specific h1 height.
Ref Bug 30809

Krinkle's comment:

If at all possible, we should consider looking for another way. I'm not marking 
fixme as I don't if it is inevitable in this case (tagging todo instead), but 
there should be no need for <code>!important</code> in core MediaWiki. Doing so 
makes future development harder than it needs to be.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to