"Dantman" posted a comment on MediaWiki.r105919.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105919#c29241
Commit summary for MediaWiki.r105919:
Replace get{Local,Full,Link,Canonical}URL's $variant argument with a secondary
$query argument and treat variant paths like we do action paths.
Dantman's comment:
It's not an error it's a valid pattern. The only thing we should consider an
error for is the simple variant strings.
<source lang=php>
// [...]
function mySpecialURL( $query ) {
// [...]
return $someTitle->getLocalURL( $query, array( 'variant' => 'zh-tw' ) );
}
// [...]
</source>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
