"Hashar" posted a comment on MediaWiki.r105919.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105919#c30214
Commit summary for MediaWiki.r105919:
Replace get{Local,Full,Link,Canonical}URL's $variant argument with a secondary
$query argument and treat variant paths like we do action paths.
Hashar's comment:
> Why new -> resolved instead of new -> ok? What's the real status of this
> commit then
I did not like how this revision kept the second parameter to get.*URL()
methods but did not think it was worth a fixme cause the code is fine. More
like a todo.
I did fix the "issue" with r109161, so I marked this revision as resolved. That
is also a good indicator that if we merge this revision, it needs to be merged
together with another revision.
Anyway, resolved is more or less the same as new :D Hope it is clearer for you
Liangent. If not, please ask!
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
