"Reedy" posted a comment on MediaWiki.r108502. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108502#c29296
Commit summary for MediaWiki.r108502: Noticed looking at schema posted by Joerg in bug 33228 It seems many ancient tables (removed mainly in 1.4, and some in 1.6) Kill them with fire, if they've still got unmigrated data in or something, we've got bigger issues! Noticed "user_rights" table is not documented at Manual:Database_layout Reedy's comment: But when they haven't been referenced in 5+ years of trunk? Granted, just a recent upgrade might still need it I don't see a point in keeping ancient out of date data "just in case". It's a stupid reason. It's also a bit late to be noticing that something we did half a decade ago had issues. Chances are, that we didn't need that data anyway But just because they aren't empty, doesn't that the data has been successfully migrated and isn't already usable in the transformed/upgraded/renamed tables For enwiki, for example, what if we kept all these old tables around, how much data duplication is that? What's the point of keeping it for no gain? Read this, for example: http://eandt.theiet.org/magazine/2011/12/dump-that-data.cfm I can somewhat see Roblas point of "don't do this now", which makes sense, but similarly, there'd be no more/less issue doing it at the start of 1.20. The data still hasn't been used in X time. Certainly dropping trackback in the same release as it was deprecated/removed is gung-ho, and that's fair enough _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
