"Dantman" posted a comment on MediaWiki.r108502.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108502#c29303

Commit summary for MediaWiki.r108502:

Noticed looking at schema posted by Joerg in bug 33228

It seems many ancient tables (removed mainly in 1.4, and some in 1.6)

Kill them with fire, if they've still got unmigrated data in or something, 
we've got bigger issues!

Noticed "user_rights" table is not documented at Manual:Database_layout

Dantman's comment:

I still don't want to see this come back, even in 1.20.

The data's existence does not harm MediaWiki's functioning. If this data is not 
migrated by the installer then this would delete the very data remaining that a 
dba could use to fix the issue.

If we do start getting complaints "Uhm, when I upgraded from 1.x to 1.y all the 
data in <x> feature disappeared" (people don't upgrade from old versions often) 
and we say "Looks like we never bothered to migrate that data, we'll have to 
add a new migration", we '''don't''' want to actually have to say "Looks like 
we never bothered to migrate that data, however because Reedy introduced a 
migration that deletes old data all that data you had has been permanently 
deleted and we cannot fix the issue with your wiki even by patching the issue 
and issuing a new release of MediaWiki."

We're supposed to try and aim for more reliability for upgrading from old 
versions of MediaWiki to newer ones, not less. Aiming for less will just give 
people more excuses not to upgrade, and that's not what we want.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to