"Aaron Schulz" posted a comment on MediaWiki.r108569.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108569#c29331

Commit summary for MediaWiki.r108569:

added feature to shard on some, all, or no containers
fixed bug 32864 - duplicate slashes in the URL should be ignored
fixed bug 33620 - AUTH prohibited in the media URL
increased the specificity of the regex to match for the URL

Aaron Schulz's comment:

The "(?P<proj>[^/]*?)/(?P<lang>[^/]*?)" still should be changed to 
"(?P<proj>[^/]+?)/(?P<lang>[^/]+?)".

"container += "-%s" % shard[2:4]" should be "container += ".%s" % shard[2:4]".

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to