"Catrope" changed the status of MediaWiki.r108563 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108563#c29333

Old Status: new
> New Status: fixme

Commit summary for MediaWiki.r108563:

make user contrib log reason translatable, add/document reason in language file 
r108484

Catrope's comment:

<pre>
+               $reason = wfMessage( 'moodbar-log-reason' )->params( 
$params['type'], $params['comment'] )->escaped();
</pre>
This'll lead to double-escaping, LogPage::addEntry() handles escaping itself. 
Use <code>->text()</code> rather than <code>->escaped()</code> .

OK otherwise.

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to