"Aaron Schulz" changed the status of MediaWiki.r108610 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108610#c29435
Old Status: new > New Status: ok Commit summary for MediaWiki.r108610: Moved RessourceLoader modules and stylesheet related stuff from EditPage::edit() to EditPage::setHeaders() and header messages to EditPage::showHeader(); there's no point running all that code when the edit form is not displayed (e.g. page save). Aaron Schulz's comment: Would be nice if showHeader() always returned a value (rather than implicit null). This was pre-existing of course. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
