"^demon" changed the status of MediaWiki.r109161 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109161#c29814
Old Status: new > New Status: fixme Commit summary for MediaWiki.r109161: deprecated $query2 in Title.php $query2 was used to pass a variant. Make that deprecated, the recommanded way is to use an array as a first parameter. Ex: $this->getLocalUrl( array( 'variant' => 'foo' ) ); Ping r105919 ^demon's comment: This doesn't accomplish anything really, fixUrlQueryArgs() is private, so nothing outside of this class can possibly be using it. Why not just fix those 4 callers rather than doing this? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
