"Tim Starling" posted a comment on MediaWiki.r109227. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109227#c30000
Commit summary for MediaWiki.r109227: Added php-cloudfiles (verbatim) with a thin MediaWiki extension wrapper around it. Custom modifications will also be maintained here. Tim Starling's comment: CF_Object::compute_md5sum() acts as a single entry point for hashing both files (by path) and strings. It does is_file() to decide which action to take. So if the file is missing for some reason, the result will be counterintuitive, and if you use it to hash a string, it will attempt to do syscalls to check if huge bogus paths exist. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
