"Tim Starling" posted a comment on MediaWiki.r109227. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109227#c30001
Commit summary for MediaWiki.r109227: Added php-cloudfiles (verbatim) with a thin MediaWiki extension wrapper around it. Custom modifications will also be maintained here. Tim Starling's comment: define()s at the top of cloudfiles.php and cloudfiles_http.php may conflict with other extensions, especially USER_AGENT, DESTINATION, AUTH_TOKEN. Suggest a CF_ prefix on all. The author does not appear to be aware of the global scope of constants in PHP, as opposed to the file scope of such constants in C. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
