"Krinkle" posted a comment on MediaWiki.r109993.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109993#c30026
Commit summary for MediaWiki.r109993:
[Html] Unit test + bugfix Html::namespaceSelector
* Previously it was passing $selectAttribs['name'] to Xml::label, which uses
its value for the <label for=""> attribute. This works as long as
$selectAttribs['id'] and $selectAttribs['name'] match, but when they don't it
fails. <label for=""> always corresponds with <{input,text area,select} id="">
in browsers, never with "name".
* Make name/id match eachother by default to avoid backwards compatibility
breakages (they used to match in the Xml class method as well)
* Add HtmlTest.php entries similar to the ones in XmlTest
* Fix E_NOTICE about $params['selected'], default to ''
-- Follows-up r109974, r109698, r109990
-- Bug originally introduced in r41425
-- XmlTest.php still runs successfully
-- HtmlTest.php runs successfully
Krinkle's comment:
Broke unit test:
http://integration.mediawiki.org/ci/job/MediaWiki-sqlite-phpunit/6351/
<pre>[exec] There were 3 failures:
[exec]
[exec] 1) ParserTests::testParserTest with data set #35 ('Definition list
with wikilink containing colon', '; [[Help:FAQ]]: The least-read page on
Wikipedia', '<dl><dt> <a
href="/index.php?title=Help:FAQ&action=edit&redlink=1" class="new"
title="Help:FAQ (page does not exist)">Help:FAQ</a></dt><dd> The least-read
page on Wikipedia
[exec] </dd></dl>
[exec] ', '', '')
[exec] Definition list with wikilink containing colon
[exec] Failed asserting that two strings are equal.
[exec] --- Expected
[exec] +++ Actual
[exec] @@ @@
[exec] -<dl><dt> <a
href="/index.php?title=Help:FAQ&action=edit&redlink=1" class="new"
title="Help:FAQ (page does not exist)">Help:FAQ</a></dt><dd> The least-read
page on Wikipedia
[exec] +<dl><dt> <a
href="/index.php?title=:FAQ&action=edit&redlink=1" class="new"
title=":FAQ (page does not exist)">Help:FAQ</a></dt><dd> The least-read page on
Wikipedia
[exec] </dd></dl>
[exec]
[exec]
/var/lib/jenkins/jobs/MediaWiki-sqlite-phpunit/workspace/mw-core/tests/phpunit/includes/parser/NewParserTest.php:547
[exec]
/var/lib/jenkins/jobs/MediaWiki-sqlite-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:66
[exec]
/var/lib/jenkins/jobs/MediaWiki-sqlite-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:45
[exec]
/var/lib/jenkins/jobs/MediaWiki-sqlite-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
[exec]
[exec] 2) ParserTests::testParserTest with data set #330 ('Link to
category', '[[:Category:MediaWiki User\'s Guide]]', '<p><a
href="/wiki/Category:MediaWiki_User%27s_Guide" title="Category:MediaWiki
User\'s Guide">Category:MediaWiki User\'s Guide</a>
[exec] </p>', '', '')
[exec] Link to category
[exec] Failed asserting that two strings are equal.
[exec] --- Expected
[exec] +++ Actual
[exec] @@ @@
[exec] -<p><a href="/wiki/Category:MediaWiki_User%27s_Guide"
title="Category:MediaWiki User's Guide">Category:MediaWiki User's Guide</a>
[exec] +<p><a href="/wiki/:MediaWiki_User%27s_Guide" title=":MediaWiki
User's Guide">Category:MediaWiki User's Guide</a>
[exec] </p>
[exec]
[exec]
/var/lib/jenkins/jobs/MediaWiki-sqlite-phpunit/workspace/mw-core/tests/phpunit/includes/parser/NewParserTest.php:547
[exec]
/var/lib/jenkins/jobs/MediaWiki-sqlite-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:66
[exec]
/var/lib/jenkins/jobs/MediaWiki-sqlite-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:45
[exec]
/var/lib/jenkins/jobs/MediaWiki-sqlite-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
[exec]
[exec] 3) ParserTests::testParserTest with data set #331 ('Simple
category', '[[Category:MediaWiki User\'s Guide]]', '<a
href="/wiki/Category:MediaWiki_User%27s_Guide" title="Category:MediaWiki
User\'s Guide">MediaWiki User\'s Guide</a>', 'cat', '')
[exec] Simple category
[exec] Failed asserting that two strings are equal.
[exec] --- Expected
[exec] +++ Actual
[exec] @@ @@
[exec] -<a href="/wiki/Category:MediaWiki_User%27s_Guide"
title="Category:MediaWiki User's Guide">MediaWiki User's Guide</a>
[exec] +<a
href="/index.php?title=MediaWiki_User%27s_Guide&action=edit&redlink=1"
class="new" title="MediaWiki User's Guide (page does not exist)">MediaWiki
User's Guide</a>
[exec]
[exec]
/var/lib/jenkins/jobs/MediaWiki-sqlite-phpunit/workspace/mw-core/tests/phpunit/includes/parser/NewParserTest.php:547
[exec]
/var/lib/jenkins/jobs/MediaWiki-sqlite-phpunit/workspace/mw-core/tests/phpunit/MediaWikiTestCase.php:66
[exec]
/var/lib/jenkins/jobs/MediaWiki-sqlite-phpunit/workspace/mw-core/tests/phpunit/MediaWikiPHPUnitCommand.php:45
[exec]
/var/lib/jenkins/jobs/MediaWiki-sqlite-phpunit/workspace/mw-core/tests/phpunit/phpunit.php:60
[exec]
</pre>
Fixed in r109994.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
