"Aaron Schulz" posted a comment on MediaWiki.r109993.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109993#c30326
Commit summary for MediaWiki.r109993:
[Html] Unit test + bugfix Html::namespaceSelector
* Previously it was passing $selectAttribs['name'] to Xml::label, which uses
its value for the <label for=""> attribute. This works as long as
$selectAttribs['id'] and $selectAttribs['name'] match, but when they don't it
fails. <label for=""> always corresponds with <{input,text area,select} id="">
in browsers, never with "name".
* Make name/id match eachother by default to avoid backwards compatibility
breakages (they used to match in the Xml class method as well)
* Add HtmlTest.php entries similar to the ones in XmlTest
* Fix E_NOTICE about $params['selected'], default to ''
-- Follows-up r109974, r109698, r109990
-- Bug originally introduced in r41425
-- XmlTest.php still runs successfully
-- HtmlTest.php runs successfully
Aaron Schulz's comment:
On my wiki (using Win 7, PHP 5.3.0):
<pre>
1) HtmlTest::testNamespaceSelector
Basic namespace selector without custom options
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
<select id="namespace" name="namespace">
<option value="0">(Main)</option>
<option value="1">Talk</option>
<option value="2">User</option>
<option value="3">User talk</option>
<option value="4">MyWiki</option>
<option value="5">MyWiki Talk</option>
<option value="6">File</option>
<option value="7">File talk</option>
<option value="8">MediaWiki</option>
<option value="9">MediaWiki talk</option>
<option value="10">Template</option>
<option value="11">Template talk</option>
<option value="100">Custom</option>
<option value="101">Custom talk</option>
</select>
C:\wamp\www\MediaWiki\tests\phpunit\includes\HtmlTest.php:234
C:\wamp\www\MediaWiki\tests\phpunit\MediaWikiTestCase.php:70
C:\wamp\www\MediaWiki\tests\phpunit\MediaWikiPHPUnitCommand.php:45
C:\wamp\www\MediaWiki\tests\phpunit\phpunit.php:60
2) XmlTest::testNamespaceSelector
Basic namespace selector without custom options
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
<select class="namespaceselector" id="namespace" name="namespace">
<option value="0">(Main)</option>
<option value="1">Talk</option>
<option value="2">User</option>
<option value="3">User talk</option>
<option value="4">MyWiki</option>
<option value="5">MyWiki Talk</option>
<option value="6">File</option>
<option value="7">File talk</option>
<option value="8">MediaWiki</option>
<option value="9">MediaWiki talk</option>
<option value="10">Template</option>
<option value="11">Template talk</option>
<option value="100">Custom</option>
<option value="101">Custom talk</option>
</select>
C:\wamp\www\MediaWiki\tests\phpunit\includes\XmlTest.php:216
C:\wamp\www\MediaWiki\tests\phpunit\MediaWikiTestCase.php:70
C:\wamp\www\MediaWiki\tests\phpunit\MediaWikiPHPUnitCommand.php:45
C:\wamp\www\MediaWiki\tests\phpunit\phpunit.php:60
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
