"Krinkle" posted a comment on MediaWiki.r109994.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109994#c30027

Commit summary for MediaWiki.r109994:

Fix broken unit test
* r109993 broke the test by overwriting namespaces it tried to preserve
* tearDown should always have the opposite order of the overrides in setUp
* Adding wgLanguageCode while at it, no reason not to, just in case.

-- Follows-up r109993

Krinkle's comment:

In practice restoring <code> namespaceNames</code> in tearDown is pointless as 
it's parent object is overwritten two lines further, just keeping is 
simple/consistent/ future proof

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to