"Tim Starling" changed the status of MediaWiki.r108369 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108369#c30054
Old Status: new
> New Status: ok
Commit summary for MediaWiki.r108369:
* Fixed 'success' value of doOperations() Status to match documentation.
* Made 'success', 'successCount', and 'failCount' fields reflect the overall
operation in FileBackendMultiWrite::doOperationsInternal(). This makes it match
up with single-write backends.
* Made FileBackend::clearCache() part of the public API.
Tim Starling's comment:
<pre>
+ return preg_replace(
+ '!^mwstore://([^/]+)!',
+ "mwstore://{$this->name}",
+ $paths // string or array
+ );
</pre>
If you're worried about metacharacters like "$" in $this->name, you can use
StringUtils::escapeRegexReplacement() to escape the replacement string
appropriately.
<pre>
abstract public function clearCache( array $paths = null );
</pre>
Can this be a no-op instead of abstract, to make it easier to write
FileBackendBase subclasses?
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
