"Catrope" changed the status of MediaWiki.r109390 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109390#c30055
Old Status: new > New Status: fixme Commit summary for MediaWiki.r109390: Fix AFT5 special page translation again - looks like it got clobbered in r109368. Also add some SQL to reload the filter_counts, though they don't update on the special page yet. Catrope's comment: <pre>+INSERT INTO aft_article_filter_count(afc_page_id, afc_filter_name, afc_filter_count) SELECT af_page_id, 'abuse', COUNT(*) FROM aft_article_feedback WHERE af_abuse_count = 0 GROUP BY af_page_id;</pre> Is this semantically correct? It seems weird to count the rows with abuse count ''equals zero'' and call that the number of abuse entries. <pre> + . $this->msg( 'articlefeedbackv5-percent-found', $found ) # Can't escape this, need the <span> tag to parse. </pre> Sure, but don't use implicit stringification of Message objects, explicitly use ->plain() here (or ->text() if the translations need to use PLURAL). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
